Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Natural list #103

Open
akshaybabloo opened this issue Mar 28, 2023 · 2 comments · May be fixed by #110
Open

Feature: Natural list #103

akshaybabloo opened this issue Mar 28, 2023 · 2 comments · May be fixed by #110
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@akshaybabloo
Copy link

I was wondering if we can have a feature that converts a list to a sentence; example - ["dog", "cat", "mouse"] and convert it to Dog, Cat and Mouse.

I can add this feature if you are up for it. Thanks.
@hugovk
Copy link
Member

hugovk commented Apr 2, 2023

Thanks for the suggestion.

That would be useful, and could be implemented along the lines of https://stackoverflow.com/a/32008908/724176

Let's leave the capitalisation out.

We could also have an input parameter to choose whether to use Oxford commas (a, b, and c) or AP style (a, b and c). And maybe to also change the "and" to "or" or something else. But let's defer those for followups if there's actual demand for it.

@hugovk hugovk added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 2, 2023
@akshaybabloo
Copy link
Author

Yeah that's what I have been using so far.

@akshaybabloo akshaybabloo linked a pull request Apr 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add naturallist akshaybabloo/humanize
2 participants
@hugovk @akshaybabloo