Feat: add support for instance variables API #1163
Merged
+443
−117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1143.
I turned objects into a subpackage here as it's getting more and more convoluted to find the right spot to shove them into
objects.py
😁. Would this work? If so I can try to split more in a separate PR.Also, got some super repetitive tests here unfortunately as I wanted to also add missing project/group vars. Would be nice to parametrize fixtures (gl/group/project, and have just 1 set of tests), but I didn't find a clean way to do it as you would with params. This is the closest I found, any more ideas? https://stackoverflow.com/a/56871701