Skip to content

Feat: add support for instance variables API #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

nejch
Copy link
Member

@nejch nejch commented Aug 30, 2020

Closes #1143.

I turned objects into a subpackage here as it's getting more and more convoluted to find the right spot to shove them into objects.py 😁. Would this work? If so I can try to split more in a separate PR.

Also, got some super repetitive tests here unfortunately as I wanted to also add missing project/group vars. Would be nice to parametrize fixtures (gl/group/project, and have just 1 set of tests), but I didn't find a clean way to do it as you would with params. This is the closest I found, any more ideas? https://stackoverflow.com/a/56871701

@nejch nejch requested a review from max-wittig August 30, 2020 16:40
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work as always, just a small suggestion. Let me know what you think!

Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work as always! 👍

Just a small suggestion. Let me know what you think!

@nejch nejch assigned max-wittig and unassigned nejch Aug 31, 2020
@nejch nejch force-pushed the feat/instance-variables-api branch from 717e257 to 5a56b6b Compare August 31, 2020 21:49
@max-wittig max-wittig merged commit 723ca88 into master Sep 1, 2020
@nejch nejch deleted the feat/instance-variables-api branch May 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for instance-level CI/CD variables
2 participants