Typo in the code?
#1857
-
I found line 362 in |
Beta Was this translation helpful? Give feedback.
Answered by
nejch
Jan 22, 2022
Replies: 1 comment 1 reply
-
Hi @skylarl07, I don't think so. The code is saying "if no Either way, that line has been in the codebase for 5 years with plenty of testing and use in the wild, so should be fine, unless you had some specific concerns there. I hope that answers your question, but let us know otherwise! |
Beta Was this translation helpful? Give feedback.
1 reply
Answer selected by
nejch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @skylarl07, I don't think so. The code is saying "if no
path
is supplied as an argument to the method, use the class instance's ownself._path
. In the next if block, if thepath
is stillNone
, then returnNone
.Either way, that line has been in the codebase for 5 years with plenty of testing and use in the wild, so should be fine, unless you had some specific concerns there. I hope that answers your question, but let us know otherwise!