-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interconnect function strange behavior #952
Comments
The error is happening because of the way that signals are named. In the command
you are creating a system "sumblk" with inputs "ref" and "p.y[0]". When you list the connections in the The seemingly correct command to getting everything up like you want would be
However, if you try that in the current main branch, you will get an error because signal names are not allowed to include '.' (not sure what version you are running, but apparently something earlier than did not have this check). To get what (I think) you want, use
and
Note that in adddition to changing the signal names, I also changed the connections to be a list of lists, as required in the current main branch (that was a change when vector signals were introduced). |
Thank you, Richard, it works now. I am curious about why there is an asymmetry between the signals
I might be missing the reason that led you to remove the possibility of naming signals with a dot (and hence having double dots in summing junctions). |
The reason for now allowing the dot was because systems can be nested and so "a.b.y[0]" could mean the signal "b.y[0]" coming out of the block "a" or "a" could be an interconnected system with subsystem "b" and you could mean "y[0]" from that (internal) subsystem. This "nested" functionality is not actually implemented, so perhaps the better solution would just be to allow arbitrary signal names. In terms of the asymmetry with the system input signal names (eg, "ref") and the internal connections, I agree that this should be generalized so that if you specify a signal name that is unique, then the system need not be specified. I'm tagging this issue as an enhancement as a flag for someone (perhaps me, someday) to implement that functionality. |
Hello,
I am testing the
interconnect
function to integrate it within nodedge editor, but I don't understand the behavior in theexample_with_connections
.In particular, I have the following warning:
And the step response is not the same as for the
example_with_explicit_signals
.Can you please explain me what I am doing wrong?
Best regards.
Anthony.
The text was updated successfully, but these errors were encountered: