Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyString.__rmod__ is unused? #234

Open
andreymal opened this issue Sep 4, 2023 · 1 comment
Open

LazyString.__rmod__ is unused? #234

andreymal opened this issue Sep 4, 2023 · 1 comment

Comments

@andreymal
Copy link

It is broken. If you call it directly, you get an incorrect result because of a typo:

>>> lazy_string = lazy_gettext(u'test')
>>> lazy_string.__rmod__('Hello %s!')
'Hello %s!test'

But the test in test_lazy_old_style_formatting is actually passing! I guess this is because Python calls str.__mod__('Hello %s!', lazy_string) instead.

This means that LazyString.__rmod__ is probably never used. Maybe just remove it?

@andreymal
Copy link
Author

A way to call it indirectly:

class MyClass:
    def __add__(self, other):
        return "myclass " + other

print(MyClass() % lazy_string)

but I don't know if anyone does that in real code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant