align license with OSI template #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview Description I am not sure why but github isn't detecting your use of the BSD-3-Clause properly. I am trying to automate an overview of the licenses included in my projects and currently I cannot detect the license using dependabots database. For example here it works: https://github.com/pallets/click/blob/main/LICENSE.rst I suspect it is due to including the text `All rights reserved.` and/or other differences which isn't part of the license template https://opensource.org/licenses/BSD-3-Clause Maybe also due to formatting but I kept things formatted to a similar character length per line as in the current version. Would you accept a PR this to hopefully fix Github's ability to detect the license and to bring your license inline with the template?
|
Codecov Report
@@ Coverage Diff @@
## master #912 +/- ##
==========================================
- Coverage 91.33% 90.58% -0.75%
==========================================
Files 21 21
Lines 4176 4122 -54
==========================================
- Hits 3814 3734 -80
- Misses 362 388 +26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akx
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
It looks like "All Rights Reserved" has inadvertently been there forever (00f16f9) and doesn't really belong in the file.
The change
-The name of the author
+Neither the name of the copyright holder nor the names of its contributorsis also benign: spdx/license-list-XML#399
discussed on legal call today; we agree that these two wordings are identical and they should be marked up to both match BSD-3 clause.
Thank you!
bors bot
added a commit
to microsoft/Qcodes
that referenced
this pull request
Nov 2, 2022
4784: Update babel requirement from ~=2.10.3 to ~=2.11.0 r=jenshnielsen a=dependabot[bot] Updates the requirements on [babel](https://github.com/python-babel/babel) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/python-babel/babel/releases">babel's releases</a>.</em></p> <blockquote> <h2>Version 2.11.0</h2> <p>The below release notes are auto-generated; please see <code>CHANGES.rst</code> for a human-crafted one.</p> <p>Thank you to all contributors!</p> <h2>What's Changed</h2> <ul> <li>tests: Use bare asserts and pytest.raises by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/875">python-babel/babel#875</a></li> <li>Use email.Message for pofile header parsing by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/876">python-babel/babel#876</a></li> <li>Become 2.10.2 by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/884">python-babel/babel#884</a></li> <li>Build packages in CI by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/888">python-babel/babel#888</a></li> <li>Become 2.10.3 by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/889">python-babel/babel#889</a></li> <li>Small downloader improvements by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/894">python-babel/babel#894</a></li> <li>Update Python versions in dev docs by <a href="https://github.com/rnestler"><code>`@rnestler</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/898">python-babel/babel#898</a></li> <li>Remove <code>__nonzero__</code> methods by <a href="https://github.com/sobolevn"><code>`@sobolevn</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/896">python-babel/babel#896</a></li> <li>Remove superfluous <code>__unicode__</code> declarations by <a href="https://github.com/lukasjuhrich"><code>`@lukasjuhrich</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/905">python-babel/babel#905</a></li> <li>align license with OSI template by <a href="https://github.com/lsmith77"><code>`@lsmith77</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/912">python-babel/babel#912</a></li> <li>Support for hex escapes in JavaScript strings by <a href="https://github.com/codepainters"><code>`@codepainters</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/877">python-babel/babel#877</a></li> <li>Remove determining time zone via systemsetup on macOS by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/914">python-babel/babel#914</a></li> <li>Add support for compact decimal formats by <a href="https://github.com/DenverCoder1"><code>`@DenverCoder1</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/909">python-babel/babel#909</a></li> <li>Adapt parse_date to handle ISO dates by <a href="https://github.com/ericzolf"><code>`@ericzolf</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/842">python-babel/babel#842</a></li> <li>Use <code>ast</code> instead of <code>eval</code> for string extraction by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/915">python-babel/babel#915</a></li> <li>Python 3.11 compatibility by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/913">python-babel/babel#913</a></li> <li>Quiesce pytest warnings by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/916">python-babel/babel#916</a></li> <li>Become 2.11.0 by <a href="https://github.com/akx"><code>`@akx</code></a>` in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/917">python-babel/babel#917</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/rnestler"><code>`@rnestler</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/898">python-babel/babel#898</a></li> <li><a href="https://github.com/sobolevn"><code>`@sobolevn</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/896">python-babel/babel#896</a></li> <li><a href="https://github.com/lukasjuhrich"><code>`@lukasjuhrich</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/905">python-babel/babel#905</a></li> <li><a href="https://github.com/lsmith77"><code>`@lsmith77</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/912">python-babel/babel#912</a></li> <li><a href="https://github.com/codepainters"><code>`@codepainters</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/877">python-babel/babel#877</a></li> <li><a href="https://github.com/DenverCoder1"><code>`@DenverCoder1</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/909">python-babel/babel#909</a></li> <li><a href="https://github.com/ericzolf"><code>`@ericzolf</code></a>` made their first contribution in <a href="https://github-redirect.dependabot.com/python-babel/babel/pull/842">python-babel/babel#842</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/python-babel/babel/compare/v2.10.3...v2.11.0">https://github.com/python-babel/babel/compare/v2.10.3...v2.11.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/python-babel/babel/blob/master/CHANGES.rst">babel's changelog</a>.</em></p> <blockquote> <h2>Version 2.11.0</h2> <p>Upcoming deprecation</p> <pre><code> * This version, Babel 2.11, is the last version of Babel to support Python 3.6. Babel 2.12 will require Python 3.7 or newer. <p>Improvements</p> <pre><code> * Support for hex escapes in JavaScript string literals :gh:`[#877](python-babel/babel#877 - Przemyslaw Wegrzyn * Add support for formatting decimals in compact form :gh:`[#909](python-babel/babel#909 - Jonah Lawrence * Adapt parse_date to handle ISO dates in ASCII format :gh:`[#842](python-babel/babel#842 - Eric L. * Use `ast` instead of `eval` for Python string extraction :gh:`[#915](python-babel/babel#915 - Aarni Koskela * This also enables extraction from static f-strings. F-strings with expressions are silently ignored (but won't raise an error as they used to). Infrastructure </code></pre> <ul> <li>Tests: Use regular asserts and <code>pytest.raises()</code> :gh:<code>[#875](https://github.com/python-babel/babel/issues/875)</code> – Aarni Koskela</li> <li>Wheels are now built in GitHub Actions :gh:<code>[#888](https://github.com/python-babel/babel/issues/888)</code> – Aarni Koskela</li> <li>Small improvements to the CLDR downloader script :gh:<code>[#894](https://github.com/python-babel/babel/issues/894)</code> – Aarni Koskela</li> <li>Remove antiquated <code>__nonzero__</code> methods :gh:<code>[#896](https://github.com/python-babel/babel/issues/896)</code> - Nikita Sobolev</li> <li>Remove superfluous <code>__unicode__</code> declarations :gh:<code>[#905](https://github.com/python-babel/babel/issues/905)</code> - Lukas Juhrich</li> <li>Mark package compatible with Python 3.11 :gh:<code>[#913](https://github.com/python-babel/babel/issues/913)</code> - Aarni Koskela</li> <li>Quiesce pytest warnings :gh:<code>[#916](https://github.com/python-babel/babel/issues/916)</code> - Aarni Koskela</li> </ul> <p>Bugfixes</p> <pre><code> * Use email.Message for pofile header parsing instead of the deprecated ``cgi.parse_header`` function. :gh:`[#876](python-babel/babel#876 – Aarni Koskela * Remove determining time zone via systemsetup on macOS :gh:`[#914](python-babel/babel#914 - Aarni Koskela Documentation </code></pre> <ul> <li>Update Python versions in documentation :gh:<code>[#898](https://github.com/python-babel/babel/issues/898)</code> - Raphael Nestler</li> <li>Align BSD-3 license with OSI template :gh:<code>[#912](https://github.com/python-babel/babel/issues/912)</code> - Lukas Kahwe Smith</li> </ul> <h2>Version 2.10.3</h2> <p>This is a bugfix release for Babel 2.10.2, which was mistakenly packaged with outdated locale data.</p> <p>Thanks to Michał Górny for pointing this out and Jun Omae for verifying.</p> <p>This and future Babel PyPI packages will be built by a more automated process, </tr></table> </code></pre></p> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python-babel/babel/commit/a30d7cff7ed2df689e9539ef07104e8ea20445a9"><code>a30d7cf</code></a> Become 2.11.0</li> <li><a href="https://github.com/python-babel/babel/commit/bc9dc84876bed120c67c73bb6fcd2d8045198090"><code>bc9dc84</code></a> Quiesce pytest warnings (<a href="https://github-redirect.dependabot.com/python-babel/babel/issues/916">#916</a>)</li> <li><a href="https://github.com/python-babel/babel/commit/52b83d3630c50944e84d066808b7ec2b0a259e4d"><code>52b83d3</code></a> Setup: mark as compatible with Python 3.11</li> <li><a href="https://github.com/python-babel/babel/commit/f117ead7d512ef3c32b68db953a193c21245ad14"><code>f117ead</code></a> CI: test on Python 3.11</li> <li><a href="https://github.com/python-babel/babel/commit/2e5708f8f231696afcbea3f5803ca43b1e33bf7f"><code>2e5708f</code></a> Use <code>ast</code> instead of <code>eval</code> for string extraction</li> <li><a href="https://github.com/python-babel/babel/commit/a946ae6bad2701a021969d82b550ba6be1f5c7d7"><code>a946ae6</code></a> Adapt parse_date to handle ISO dates in ASCII format</li> <li><a href="https://github.com/python-babel/babel/commit/05df10fd1474e929793183c3b0ffa28251df79eb"><code>05df10f</code></a> Add support for compact decimal formats (<a href="https://github-redirect.dependabot.com/python-babel/babel/issues/909">#909</a>)</li> <li><a href="https://github.com/python-babel/babel/commit/03c8fae835c16d63fa5f4e3141074abb8bad3e83"><code>03c8fae</code></a> Remove determining time zone via systemsetup on macOS</li> <li><a href="https://github.com/python-babel/babel/commit/c7d04e8cb7bd60ff305d8bc6df2ce8a3f92c0223"><code>c7d04e8</code></a> Support for hex escapes in JavaScript string literals</li> <li><a href="https://github.com/python-babel/babel/commit/8f5757cc85402a46c1db722f08c18cfa7f119858"><code>8f5757c</code></a> align license with OSI template (<a href="https://github-redirect.dependabot.com/python-babel/babel/issues/912">#912</a>)</li> <li>Additional commits viewable in <a href="https://github.com/python-babel/babel/compare/v2.10.3...v2.11.0">compare view</a></li> </ul> </details> <br /> You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview Description
I am not sure why but github isn't detecting your use of the BSD-3-Clause properly.
I am trying to automate an overview of the licenses included in my projects and currently I cannot detect the license using dependabots database.
For example here it works:
https://github.com/pallets/click/blob/main/LICENSE.rst
I suspect it is due to including the text
All rights reserved.and/or other differences which isn't part of the license template https://opensource.org/licenses/BSD-3-ClauseMaybe also due to formatting but I kept things formatted to a similar character length per line as in the current version.
Would you accept a PR this to hopefully fix Github's ability to detect the license and to bring your license inline with the template?