Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail with pytest 6 #747

Closed
eli-schwartz opened this issue Oct 30, 2020 · 3 comments
Closed

tests fail with pytest 6 #747

eli-schwartz opened this issue Oct 30, 2020 · 3 comments

Comments

@eli-schwartz
Copy link

eli-schwartz commented Oct 30, 2020

Attempting to rebuild python-babel 2.8.0 for Arch Linux without changes, but with a system pytest 6 package, I get the following error:

============================= test session starts ==============================
platform linux -- Python 3.8.6, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
rootdir: /build/python-babel/src/babel-2.8.0, configfile: setup.cfg
collected 0 items / 1 error

==================================== ERRORS ====================================
________________________ ERROR collecting test session _________________________
Direct construction of DoctestModule has been deprecated, please use DoctestModule.from_parent.
See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.
=========================== short test summary info ============================
ERROR 
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.09s ===============================
@akx
Copy link
Member

akx commented Nov 11, 2020

Fixed by #752. Would a 2.8.1 patch release help?

@eli-schwartz
Copy link
Author

eli-schwartz commented Nov 11, 2020

Yes please, if that would be convenient. :)

We are currently doing python 3.9 rebuilds (as of 2 days ago), so we need to have the fix ASAP. And it's more convenient to bump the version to 2.8.1 than to backport the fix.

@akx
Copy link
Member

akx commented Nov 11, 2020

@eli-schwartz 2.8.1 is now up on PyPI and as a tag in this repo. Sorry for the inconvenience and thanks for the bug report!

A 2.9.0 release with functional changes over 2.8.0 is also forthcoming – maybe not today but soon enough 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants