Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation "Number parsing is not properly implemented yet" #692

Closed
dadonzg opened this issue Feb 4, 2020 · 2 comments · Fixed by #708
Closed

Documentation "Number parsing is not properly implemented yet" #692

dadonzg opened this issue Feb 4, 2020 · 2 comments · Fixed by #708

Comments

@dadonzg
Copy link

dadonzg commented Feb 4, 2020

Good Morning,

First thank you for this very helpful library,

I have a question related to the documentation,

On https://github.com/python-babel/babel/blob/master/docs/numbers.rst#parsing-numbers

You are saying:

Number parsing is not properly implemented yet

Is it related to only parse_number or also to parse_decimal ?

Thank you,

@bradleypmartin
Copy link
Contributor

Hey @dadonzg, thanks for your input - I'm going to check this out a little bit today.

I'm guessing this has to do with the parse_number function not being implemented, but if so, I agree - we could make that a little more explicit/clear in the docs.

@bradleypmartin
Copy link
Contributor

Hey once more, dadonzg! Just wanted to update you with what I'd found and done today. I checked out the source and did some testing of my own with both the parse_decimal and parse_number functions (and some of those tests are reflected in the PR now linked here: #708)

The parse_number logic is indeed implemented, but isn't built out to the same extent that parse_decimal is - particularly in regard to handling special cases (including the 'ru' locale space parsing issue that I included in the docs PR above).

So after investigation, I believe your question definitely relates at least more to parse_number, and I've tried to clear that up in the PR.

@akx akx closed this as completed in #708 May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants