Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support match case destructuring in Python 3.10 using __match_args__ #814

Closed
tirkarthi opened this issue May 13, 2021 · 3 comments · Fixed by #815
Closed

Support match case destructuring in Python 3.10 using __match_args__ #814

tirkarthi opened this issue May 13, 2021 · 3 comments · Fixed by #815
Labels

Comments

@tirkarthi
Copy link
Contributor

In Python 3.10 match/case syntax was added that also has destructuring syntax. dataclass supports this feature and has option to disable this. The current logic is at https://github.com/python/cpython/blob/366c69f3f63a2a1cce57dabe8f7c2e67d1df625d/Lib/dataclasses.py#L374 where init and kw_only are checked.

dataclass had some discussion and added support where __match_args__ generation can be disabled if needed : https://bugs.python.org/issue43764

I have a patch locally working. I can write some tests. But I will be happy to know if a PR is accepted and if an option to disable matching is needed like dataclasses.

attrs

# /tmp/attrs_match.py    
import attr

@attr.s
class AttrPerson:
    name = attr.ib()

person = AttrPerson(name="Kate")

match person:
    case AttrPerson(name):
        print(f"Found {name}")
    case _:
        print("Not found")
python /tmp/attrs_match.py
Traceback (most recent call last):
  File "/tmp/attrs_match.py", line 10, in <module>
    case AttrPerson(name):
TypeError: AttrPerson() accepts 0 positional sub-patterns (1 given)

Dataclasses

# /tmp/dataclass_match.py 
from dataclasses import dataclass

@dataclass
class Person:
    name: str

    
person = Person(name="Kate")

match person:
    case Person(name):
        print(f"Found {name}")
    case _:
        print("Not found")
$ python /tmp/dataclass_match.py 
Found Kate
@tirkarthi
Copy link
Contributor Author

An implementation with tests : tirkarthi@452b09a

@wsanchez
Copy link

@tirkarthi Thanks for working on this. I suspect that a PR would be welcome here.

@tirkarthi
Copy link
Contributor Author

Thanks @wsanchez , I have created #815 for review.

@wsanchez wsanchez linked a pull request May 14, 2021 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants