Ignore inherited field when comparing Attributes #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hynek
force-pushed
the
inherited-attrs-eq-hash
branch
from
9e821a5
to
d8615d2
Compare
pganssle
approved these changes
Sep 2, 2020
pganssle
approved these changes
Sep 2, 2020
hynek
force-pushed
the
inherited-attrs-eq-hash
branch
from
fcd53c6
to
f5875ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although technically,
inheritedis part of the structure, practically it exposes a very confusing behavior because by subclassing the attribute suddenly doesn't compare equal although it is equal by all logical standards.fixes #682