Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto_attrib=None behavior when maybe_cls=None #675

Merged
merged 2 commits into from Aug 23, 2020

Conversation

euresti
Copy link
Contributor

@euresti euresti commented Aug 23, 2020

Fixes #673

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in our __init__.py file.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

tests/test_next_gen.py Outdated Show resolved Hide resolved
@euresti euresti requested a review from hynek August 23, 2020 03:28
@euresti
Copy link
Contributor Author

euresti commented Aug 23, 2020

I still need to write documentation.

Co-authored-by: David Euresti <github@euresti.com>
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll add a newsframent myself.

@hynek hynek merged commit 4cfd52d into python-attrs:master Aug 23, 2020
hynek added a commit that referenced this pull request Aug 23, 2020
@euresti euresti deleted the wrap_do_it branch February 18, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hybrid behavior doesn't work when maybe_cls=None and no annotations
2 participants