Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Python 3.4 support being dropped? #606

Closed
altendky opened this issue Jan 3, 2020 · 3 comments
Closed

Is Python 3.4 support being dropped? #606

altendky opened this issue Jan 3, 2020 · 3 comments
Labels
Cleanup

Comments

@altendky
Copy link
Contributor

altendky commented Jan 3, 2020

Looks like the tests are failing, should I PR to remove 3.4 support or is it intentionally being kept around? A quick search for 3.4 didn't turn up any other issues.
@hynek
Copy link
Member

hynek commented Jan 3, 2020

Ugh yeah, I don't want to deal with that.

Please use something like https://www.structlog.org/en/stable/changelog.html#backward-incompatible-changes as the newsfragment – thanks!

@hynek
Copy link
Member

hynek commented Jan 6, 2020

Fixed by #608

@hynek hynek closed this as completed Jan 6, 2020
@altendky
Copy link
Contributor Author

altendky commented Jan 6, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hynek @wsanchez @altendky