-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Couldn't use numpy arrays as defaults on attrs 19.2 #585
Comments
the issue can be resolved by switching the sentinel check from equality to is |
Yep, opening a PR right away |
nicoddemus
added a commit
to nicoddemus/attrs
that referenced
this issue
Oct 14, 2019
hynek
pushed a commit
that referenced
this issue
Oct 15, 2019
FYI 19.3.0 with that fix is on PyPI. Sorry for the regression and thanks to @RonnyPfannschmidt and @nicoddemus for the quick fix while I was sound asleep! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following code stops working when upgrading from attrs 19.1 to 19.2:
Seems that change #556 requires that default attributes should implement
__eq__
, which is not the case for numpy arrays.Taceback is:
The text was updated successfully, but these errors were encountered: