Remove code and tests related to deprecated 'convert' kwarg #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramatevish
force-pushed
the
remove-convert
branch
from
ec1b1a8
to
b165313
Compare
|
Woof, I'm pretty sure this is failing tests because |
|
Nice! I think I want to push 19.1 first with convert in place and emerge right after. |
|
Updated now that pytest isn't breaking. |
hynek
approved these changes
Mar 7, 2019
|
Thank you very much, I love the smell of deleted code in the morning! |
lukas-bednar
added a commit
to lukas-bednar/python-rrmngmnt
that referenced
this pull request
Oct 30, 2019
avast/pytest-docker#39 python-attrs/attrs#504 python-attrs/attrs#307 Signed-off-by: Lukas Bednar <lbednar@redhat.com>
lukas-bednar
added a commit
to rhevm-qe-automation/python-rrmngmnt
that referenced
this pull request
Oct 30, 2019
avast/pytest-docker#39 python-attrs/attrs#504 python-attrs/attrs#307 Signed-off-by: Lukas Bednar <lbednar@redhat.com>
pixelb
added a commit
to pixelb/attrs
that referenced
this pull request
Mar 25, 2020
…ython-attrs#504)" This reverts commit c2a9dd8. pytest < 4.3 uses the convert keyword at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.