Fix faulthandler for Twisted Logger when used with "--capture=no" #8250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
fix-twisted-capture
branch
2 times, most recently
from
5e52b35
to
849fa40
Compare
bluetech
reviewed
Jan 18, 2021
nicoddemus
added
the
needs backport
The Twisted Logger will return an invalid file descriptor since it is not backed by an FD. So, let's also forward this to the same code path as with `pytest-xdist`.
amotl
force-pushed
the
fix-twisted-capture
branch
from
849fa40
to
9ba1821
Compare
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Jan 20, 2021
|
Backport: #8259 |
nicoddemus
added
backported
|
Thank you for accepting this small improvement. I wish much success and kudos to all of you for the future development of |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
this patch resolves #8249.
The background on this is that the Twisted Logger will return an invalid file descriptor since it is not backed by an FD. It will make
pytestcroak and hang when invoked throughpytest --capture=noon teardown.The solution is to also forward this to the same code path as with
pytest-xdist, where the code already has special handling for.Hereby, I humbly ask for further guidance in order to bring in this patch. Please let me know
With kind regards,
Andreas.