Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved 'Declaring new hooks' section in docs. #7782

Merged
merged 5 commits into from Sep 23, 2020
Merged

Improved 'Declaring new hooks' section in docs. #7782

merged 5 commits into from Sep 23, 2020

Conversation

kamahmad
Copy link
Contributor

@kamahmad kamahmad commented Sep 22, 2020 •
edited

  1. Renamed the sample hook declaration file to "sample_hook.py" from "hooks.py".
  2. Added the @hookimpl decorator to example functions.
  3. Added name to AUTHORS.

closes #7706

@kamahmad kamahmad changed the title Improved 'Declaring new hooks' section in docs. - closes #7706 Improved 'Declaring new hooks' section in docs. Sep 22, 2020
nicoddemus
nicoddemus approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kamahmad, made some adjustments.

doc/en/writing_plugins.rst Outdated Show resolved Hide resolved
@nicoddemus nicoddemus marked this pull request as ready for review September 23, 2020 14:15
@nicoddemus nicoddemus merged commit d3f47bf into pytest-dev:master Sep 23, 2020
@nicoddemus
Copy link
Member

Thanks @kamahmad!

@kamahmad
Copy link
Contributor Author

Thanks @nicoddemus . Couldn't have done it without you help 👍

Looking forward to working on more issues. :)

@nicoddemus
Copy link
Member

Awesome, thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusion in documentation: "Declaring New Hooks"
2 participants
@kamahmad @nicoddemus