Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple issue template types and mention Discussions #7739

Merged
merged 1 commit into from Sep 21, 2020

Conversation

nicoddemus
Copy link
Member

No description provided.

Copy link
Member

@gnikonorov gnikonorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks @nicoddemus

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@The-Compiler
Copy link
Member

Wouldn't it make more sense to use GitHub's issue type selectors to point to discussions? Here's an example:

I'm -0.5 on this, as it doesn't seem to be the right mechanism and will lead to some people most likely just leaving this text inside their issues instead of deleting it.

@nicoddemus
Copy link
Member Author

nicoddemus commented Sep 11, 2020

Wouldn't it make more sense to use GitHub's issue type selectors to point to discussions?

Oh yeah I forgot a about that feature. I agree it is much nicer as well as points people in the correct direction!

Would you like to tackle that?

@nicoddemus nicoddemus changed the title Mention the new Discussions forum in the issue template Use multiple issue template types and mention Discussions Sep 19, 2020
@nicoddemus
Copy link
Member Author

@The-Compiler done, thanks!

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@The-Compiler
Copy link
Member

Looks great, thanks @nicoddemus and sorry for the delay!

@The-Compiler The-Compiler merged commit 050c2df into pytest-dev:master Sep 21, 2020
@nicoddemus nicoddemus deleted the discussions branch September 21, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants