Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest 6.1? #7703

Closed
nicoddemus opened this issue Sep 2, 2020 · 23 comments
Closed

pytest 6.1? #7703

nicoddemus opened this issue Sep 2, 2020 · 23 comments

Comments

@nicoddemus
Copy link
Member

Hi all,

The only issue still on the milestone for 6.1 is #6324, but I don't think that's a blocker and can be postponed.

Thoughts?

Also, would @bluetech like to do the honors for this release? 馃榿

@nicoddemus
Copy link
Member Author

nicoddemus commented Sep 3, 2020

Actually we probably should include #7695 as well.

@bluetech
Copy link
Member

bluetech commented Sep 4, 2020

Also, would @bluetech like to do the honors for this release?

I haven't had much luck with pytest-django but I can try :) I can handle all of the steps except for the Twitter one.

I don't remember if we landed on regarding release candidates - for major releases only or also minor?

@nicoddemus
Copy link
Member Author

I can handle all of the steps except for the Twitter one.

The tweet is usually done from your personal account, or the problem is that you don't have a twitter account?

I don't remember if we landed on regarding release candidates - for major releases only or also minor?

Just major releases, because of potential breakages.

@bluetech
Copy link
Member

bluetech commented Sep 4, 2020

The tweet is usually done from your personal account, or the problem is that you don't have a twitter account?

I don't.

Just major releases, because of potential breakages.

OK, got it.

@nicoddemus
Copy link
Member Author

I don't.

No worries, we can ask @hackebrot @The-Compiler @pfctdayelise to tweet the release from the official pytest account then. 馃憤

Btw perhaps makes sense to do a 6.0.2 as well? We do have a few bugs fixed there.

@bluetech
Copy link
Member

bluetech commented Sep 4, 2020

@pytestbot please prepare release from 6.0.x.

@bluetech
Copy link
Member

bluetech commented Sep 4, 2020

Bad dot bot!

@pytestbot please prepare release from 6.0.x

@bluetech
Copy link
Member

bluetech commented Sep 4, 2020

@pytestbot please prepare release from 6.0.x

@pytestbot

This comment has been minimized.

@bluetech
Copy link
Member

bluetech commented Sep 4, 2020

I jinxed it. Will try to figure out the problem tomorrow.

@nicoddemus
Copy link
Member Author

Heh! I will try to take a look as well.

@nicoddemus
Copy link
Member Author

I've fixed it in #7719, and while at it opened the PR for 6.0.2.

Thanks for the backports! 馃憤

@nicoddemus
Copy link
Member Author

As per #7718 (comment), let's hold a bit to implement at least some basic plugin integration testing.

@pfctdayelise
Copy link
Contributor

Am standing by for tweeting duties 馃憖馃惁
(BTW Bruno would be even better to tag @pytestdotorg in release tweets, then I will actually get notified, not just happen to notice them :))

@nicoddemus
Copy link
Member Author

BTW Bruno would be even better to tag @pytestdotorg in release tweets,

Noted, thanks Brianna!

@bluetech
Copy link
Member

Now that the plugin smoke test is in, and the problem discovered there is fixed, I intend to release 6.1 next weekend. If there are any blockers, let me know.

@nicoddemus
Copy link
Member Author

Sounds good, thanks for stepping in! 馃憤

@bluetech
Copy link
Member

@pytestbot please prepare release from 6.1.x

@pytestbot
Copy link
Contributor

Found features or breaking changes in 6.1.x, and feature releases can only be
created from master.":

  • 5585.breaking.rst
  • 7667.feature.rst

@bluetech
Copy link
Member

Oh pytestbot, what did I ever do to you??? Let's see what this is about.

@bluetech
Copy link
Member

@pytestbot please prepare release from master

@pytestbot
Copy link
Contributor

As requested, opened a PR for release 6.1.0: #7797.

@bluetech
Copy link
Member

Note: the script is out of tune with RELEASING -- the script only allows minor releases from master but RELEASING says it should be from a (newly-created) 6.1.x branch. For now I tricked the script by opening against master and switching the PR target branch from master to 6.1.x. Will follow up later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants