Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing File reference to the docs #7697

Merged
merged 1 commit into from Aug 28, 2020
Merged

Add missing File reference to the docs #7697

merged 1 commit into from Aug 28, 2020

Conversation

nicoddemus
Copy link
Member

As related in #7696

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 27, 2020
@nicoddemus nicoddemus mentioned this pull request Aug 27, 2020
Closed
asottile
asottile approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bluetech
bluetech approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current File docstring is "Base class for collecting tests from a file.". I suggest throwing a

:ref:`non-python tests`

in there for a usage explanation

@nicoddemus
Copy link
Member Author

Good idea @bluetech, done!

@nicoddemus nicoddemus merged commit 21aa6c4 into pytest-dev:master Aug 28, 2020
@nicoddemus nicoddemus deleted the file-docs branch August 28, 2020 12:52
bluetech pushed a commit to bluetech/pytest that referenced this pull request Sep 4, 2020
@nicoddemus @bluetech
Merge pull request pytest-dev#7697 from nicoddemus/file-docs
cb91c50 
(cherry picked from commit 21aa6c4)
@bluetech bluetech mentioned this pull request Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicoddemus @bluetech @asottile