New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly remove log_print #7614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
bluetech
added
the
needs backport
applied to PRs, indicates that it should be ported to the current bug-fix branch
label
Aug 4, 2020
This is a follow up to 3f82006 which didn't make it clear that log_print is also removed in the changelog and didn't remove it from the reference docs.
Something broke on CI:
See pypa/pip#8272 |
nicoddemus
approved these changes
Aug 4, 2020
Merging as the CI failure is unrelated and already being tracked in #7616. Thanks @The-Compiler! |
bluetech
pushed a commit
to bluetech/pytest
that referenced
this pull request
Sep 4, 2020
Properly remove log_print (cherry picked from commit d688fef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs backport
applied to PRs, indicates that it should be ported to the current bug-fix branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to 3f82006 which didn't
make it clear that log_print is also removed in the changelog and didn't remove
it from the reference docs.
Closes #7612