Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly remove log_print #7614

Merged
merged 1 commit into from Aug 4, 2020
Merged

Conversation

The-Compiler
Copy link
Member

This is a follow up to 3f82006 which didn't
make it clear that log_print is also removed in the changelog and didn't remove
it from the reference docs.

Closes #7612

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

doc/en/deprecations.rst Outdated Show resolved Hide resolved
@bluetech bluetech added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Aug 4, 2020
This is a follow up to 3f82006 which didn't
make it clear that log_print is also removed in the changelog and didn't remove
it from the reference docs.
@The-Compiler
Copy link
Member Author

Something broke on CI:

    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_internal\commands\install.py", line 17, in <module>
      from pip._internal.cli.req_command import RequirementCommand, with_cleanup
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_internal\cli\req_command.py", line 16, in <module>
      from pip._internal.index.collector import LinkCollector
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_internal\index\collector.py", line 14, in <module>
      from pip._vendor import html5lib, requests
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_vendor\requests\__init__.py", line 125, in <module>
      from . import utils
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_vendor\requests\utils.py", line 25, in <module>
      from . import certs
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_vendor\requests\certs.py", line 15, in <module>
      from pip._vendor.certifi import where
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_vendor\certifi\__init__.py", line 1, in <module>
      from .core import contents, where
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\pip\_vendor\certifi\core.py", line 12, in <module>
      from importlib.resources import path as get_path, read_text
    File "c:\hostedtoolcache\windows\python\3.8.5\x64\lib\importlib\resources.py", line 11, in <module>
      from typing import Iterable, Iterator, Optional, Set, Union   # noqa: F401
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\typing.py", line 1359, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "D:\a\pytest\pytest\.tox\py38-unittestextras\lib\site-packages\typing.py", line 1007, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

See pypa/pip#8272

@nicoddemus
Copy link
Member

Merging as the CI failure is unrelated and already being tracked in #7616.

Thanks @The-Compiler!

@nicoddemus nicoddemus merged commit d688fef into pytest-dev:master Aug 4, 2020
bluetech pushed a commit to bluetech/pytest that referenced this pull request Sep 4, 2020
Properly remove log_print

(cherry picked from commit d688fef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PytestConfigWarning for log_print, flake8-ignore, flake8-max-line-length
3 participants