Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about --basetemp removing the entire directory #7555

Merged
merged 4 commits into from Jul 29, 2020
Merged

Warn about --basetemp removing the entire directory #7555

merged 4 commits into from Jul 29, 2020

Conversation

mysterious-progression
Copy link
Contributor

@mysterious-progression mysterious-progression commented Jul 28, 2020 •
edited by nicoddemus

Added warning about deletion of data in the documentation of the base temporary directory

Fix #7554

The-Compiler
The-Compiler requested changes Jul 28, 2020
View reviewed changes
doc/en/tmpdir.rst Outdated Show resolved Hide resolved
@nicoddemus
Copy link
Member

You need to have a blank line after the sphinx directive, also took the liberty of improving the message a bit. 👍

Thanks @mattreex!

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jul 28, 2020
@nicoddemus nicoddemus changed the title add basetemp warning Warn about --basetemp removing the entire directory Jul 29, 2020
@nicoddemus nicoddemus merged commit 1e66ed0 into pytest-dev:master Jul 29, 2020
nicoddemus pushed a commit to nicoddemus/pytest that referenced this pull request Jul 29, 2020
@mysterious-progression @nicoddemus
Warn about --basetemp removing the entire directory (pytest-dev#7555)
2d5b8a8 
Co-authored-by: mattreex <mattreex.9@gail.com>
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
(cherry picked from commit 1e66ed0)
@nicoddemus
Copy link
Member

Backport: #7578

@mysterious-progression mysterious-progression deleted the add_basetmp_warning branch July 29, 2020 15:05
nicoddemus added a commit that referenced this pull request Jul 29, 2020
@nicoddemus
Merge pull request #7578 from nicoddemus/backport-7555
1516780 
[6.0.x] Warn about --basetemp removing the entire directory (#7555)
@nicoddemus nicoddemus added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-Compiler The-Compiler The-Compiler requested changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document --basetemp directory-clearaing behavior better
3 participants
@mysterious-progression @nicoddemus @The-Compiler