Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecation warnings into errors for 8.0 #7363

Closed
nicoddemus opened this issue Jun 13, 2020 · 8 comments
Closed

Change deprecation warnings into errors for 8.0 #7363

nicoddemus opened this issue Jun 13, 2020 · 8 comments
Assignees
Labels
type: deprecation feature that will be removed in the future
Milestone

Comments

@nicoddemus
Copy link
Member

nicoddemus commented Jun 13, 2020

Ref: #5584, #7362

Note: originally this was meant to be integrated in 7.0 in #8837, but we decided to postpone it as per #8837 (comment).

@nicoddemus nicoddemus added the type: deprecation feature that will be removed in the future label Jun 13, 2020
@nicoddemus nicoddemus added this to the 7.0 milestone Jun 13, 2020
@avats-dev
Copy link

@nicoddemus I want to work on this. Can you guide me a bit how to resolve this?
I checked refs, so should I just replace 6.0 with 7.0 (as this is already implemented and just needs to be uncommented I think).
Thanks.

@nicoddemus
Copy link
Member Author

@avats-dev thanks for the offer!

However this is only done near the actual release (and actually this is incorrect, we do this in 7.1, I've updated the milestone), and we're nowhere near that. 😁

@avats-dev
Copy link

Ok 👍

@h-vetinari
Copy link

It's a bit confusing that the original 7.0 milestone was apparently renamed to 8.0. In any case, this issue should either be renamed or remilestoned.

@nicoddemus nicoddemus modified the milestones: 8.0, 7.0 Jun 29, 2021
@The-Compiler The-Compiler added this to Needs consensus/investigation in 7.0 release Jun 30, 2021
@The-Compiler
Copy link
Member

@nicoddemus Is this something you're going to look into? If not, I think this needs some more context about what should be done.

@nicoddemus
Copy link
Member Author

Sure, thanks for the ping, I will work on it.

The idea is that we configure PytestDeprecationWarnings to errors (the core of it is in #7362, in src/_pytest/warnings.py).

@nicoddemus nicoddemus self-assigned this Jun 30, 2021
@The-Compiler The-Compiler moved this from Needs consensus/investigation to In progress in 7.0 release Jun 30, 2021
nicoddemus added a commit to nicoddemus/pytest that referenced this issue Jun 30, 2021
@nicoddemus nicoddemus changed the title Change deprecation warnings into errors for 7.0 Change deprecation warnings into errors for 8.0 Jul 1, 2021
@nicoddemus nicoddemus modified the milestones: 7.0, 8.0 Jul 1, 2021
@The-Compiler The-Compiler removed this from In progress in 7.0 release Jul 3, 2021
@graingert
Copy link
Member

graingert commented Jul 29, 2022

Currently RemovedIn8Warning is declared final, but really it should be sealed, because it means pytest can't create subclasses of RemovedIn8Warning, eg ReturnNotNoneWarning

@bluetech
Copy link
Member

bluetech commented Jan 4, 2024

This was done in a4a189a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: deprecation feature that will be removed in the future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants