Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust codecov: only patch statuses, wait for CI to pass #7294

Merged
merged 1 commit into from Jun 2, 2020
Merged

Adjust codecov: only patch statuses, wait for CI to pass #7294

merged 1 commit into from Jun 2, 2020

Conversation

nicoddemus
Copy link
Member

Fix #6994

@nicoddemus
Copy link
Member Author

I expect that only codecov/patch will appear once this gets merged to master.

@gnikonorov
Copy link
Member

as per https://docs.codecov.io/docs/commit-status#excluding-tests-example, do we need to specify project as false?

coverage:
  status:
    project:
      default: false

bluetech
bluetech reviewed Jun 2, 2020
View reviewed changes
codecov.yml Outdated
comment: off
# reference: https://docs.codecov.io/docs/codecovyml-reference
codecov:
require_ci_to_pass: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the reference this is the default, so maybe want to omit.

@bluetech
Copy link
Member

bluetech commented Jun 2, 2020

I think @gnikonorov is correct, though this section https://docs.codecov.io/docs/commit-status#disabling-a-status rather suggests

coverage:
  status:
    project: off

@nicoddemus
Copy link
Member Author

You folks are right! Funny thing, I was thinking exactly that this was the correct way in the shower this morning. 😆

@nicoddemus nicoddemus requested a review from bluetech June 2, 2020 11:54
@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jun 2, 2020
@nicoddemus nicoddemus merged commit 589c6c6 into pytest-dev:master Jun 2, 2020
@nicoddemus nicoddemus deleted the codecov-adjustments branch June 2, 2020 12:02
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Jun 2, 2020
@nicoddemus
Merge pull request pytest-dev#7294 from nicoddemus/codecov-adjustments
703d0f5
@nicoddemus
Copy link
Member Author

Backport: #7299

bluetech added a commit that referenced this pull request Jun 2, 2020
@bluetech
Merge pull request #7299 from nicoddemus/backport-7294
2d6b846 
[5.4.x] Merge pull request #7294 from nicoddemus/codecov-adjustments
@nicoddemus nicoddemus added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] consider droping codecov
3 participants
@nicoddemus @gnikonorov @bluetech