Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call TestCase.tearDown for skipped tests #7236

Merged
merged 1 commit into from May 30, 2020
Merged

Do not call TestCase.tearDown for skipped tests #7236

merged 1 commit into from May 30, 2020

Conversation

nicoddemus
Copy link
Member

Fix #7215

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label May 21, 2020
asottile
asottile approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoddemus nicoddemus merged commit 56bf819 into pytest-dev:master May 30, 2020
@nicoddemus nicoddemus deleted the teardown-pdb branch May 30, 2020 17:33
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request May 30, 2020
@nicoddemus
Do not call TestCase.tearDown for skipped tests (pytest-dev#7236)
551400e 
Fix pytest-dev#7215
@nicoddemus
Copy link
Member Author

Backport: #7283

nicoddemus added a commit that referenced this pull request May 31, 2020
@nicoddemus
[5.4] Do not call TestCase.tearDown for skipped tests (#7236) (#7283)
3734a27 
[5.4] Do not call TestCase.tearDown for skipped tests (#7236)
@nicoddemus nicoddemus added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unittest.TestCase.tearDown executed on skipped tests when running --pdb
2 participants
@nicoddemus @asottile