Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _is_setup_py for files encoded differently than locale #7186

Merged
merged 1 commit into from May 7, 2020
Merged

Fix _is_setup_py for files encoded differently than locale #7186

merged 1 commit into from May 7, 2020

Conversation

asottile
Copy link
Member

@asottile asottile commented May 7, 2020 •
edited

Resolves #7180

@asottile asottile mentioned this pull request May 7, 2020
Closed
nicoddemus
nicoddemus approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label May 7, 2020
@asottile asottile merged commit 9d2eabb into pytest-dev:master May 7, 2020
@asottile asottile deleted the is_setup_py_encoding_agnostic branch May 7, 2020 21:01
@asottile asottile added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_pytest.doctest._is_setup_py raises with LC_ALL=C and UTF-8 chars in setup.py
2 participants
@asottile @nicoddemus