Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.4.1 #6915

Closed
nicoddemus opened this issue Mar 13, 2020 · 6 comments
Closed

Release 5.4.1 #6915

nicoddemus opened this issue Mar 13, 2020 · 6 comments

Comments

@nicoddemus
Copy link
Member

@pytestbot please prepare release from 5.4.x

The main reason is to resolve #6909.

@pytestbot
Copy link
Contributor

Sorry, the request to prepare release 5.4.1 from 5.4.x failed with:

Command '['/home/runner/work/pytest/pytest/.tox/release-on-comment/bin/python', 'scripts/release.py', '5.4.1']' returned non-zero exit status 1.

See: https://github.com/pytest-dev/pytest/actions/runs/55039693.

@nicoddemus
Copy link
Member Author

nicoddemus commented Mar 13, 2020

Link check is really getting into the way of getting releases out (in this case, flakyness, not because the links are actually incorrect).

I will change it to not use link checks from the release bot, we need to discuss this further how to handle this in #6894.

@nicoddemus
Copy link
Member Author

@pytestbot please prepare release from 5.4.x

@pytestbot
Copy link
Contributor

As requested, opened a PR for release 5.4.1: #6918.

@altendky
Copy link
Member

@nicoddemus
Copy link
Member Author

@altendky I remember those... it seems this time was due to rate limiting to GitHub:

/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5133: WARNING: broken link: https://github.com/eolo999 (429 Client Error: too many requests for url: https://github.com/eolo999)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5146: WARNING: broken link: https://github.com/marscher (429 Client Error: too many requests for url: https://github.com/marscher)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5150: WARNING: broken link: https://github.com/DRMacIver (429 Client Error: too many requests for url: https://github.com/DRMacIver)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5153: WARNING: broken link: https://github.com/Vogtinator (429 Client Error: too many requests for url: https://github.com/Vogtinator)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5164: WARNING: broken link: https://github.com/Stranger6667 (429 Client Error: too many requests for url: https://github.com/Stranger6667)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5167: WARNING: broken link: https://github.com/Stranger6667 (429 Client Error: too many requests for url: https://github.com/Stranger6667)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5157: WARNING: broken link: https://github.com/txomon (429 Client Error: too many requests for url: https://github.com/txomon)
/home/runner/work/pytest/pytest/doc/en/changelog.rst.rst:5170: WARNING: broken link: https://github.com/cboelsen (429 Client Error: too many requests for url: https://github.com/cboelsen)

We need to probably think of a different approach, you are welcome to join us brainstorm in #6894.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants