Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Use a dummy RemoteTraceback for test in Python 3.5 Windows #6479

Merged
merged 1 commit into from Jan 16, 2020

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 16, 2020

Somehow in Python 3.5 on Windows this test fails with:
File "c:\hostedtoolcache\windows\python\3.5.4\x64\Lib\multiprocessing\connection.py", line 302, in _recv_bytes
overlapped=True)
OSError: [WinError 6] The handle is invalid

This only happens in this platform and Python version, decided to use
a dummy traceback as originally done in #6412.

(cherry picked from commit b9c136b)

Somehow in Python 3.5 on Windows this test fails with:
   File "c:\hostedtoolcache\windows\python\3.5.4\x64\Lib\multiprocessing\connection.py", line 302, in _recv_bytes
     overlapped=True)
OSError: [WinError 6] The handle is invalid

This only happens in this platform and Python version, decided to use
a dummy traceback as originally done in pytest-dev#6412.

(cherry picked from commit b9c136b)
@blueyed
Copy link
Contributor Author

blueyed commented Jan 16, 2020

IIRC there was the same failure this was done for with a PR for master.
#6477

@nicoddemus Was this flaky in the first place only?

@nicoddemus
Copy link
Member

Was this flaky in the first place only?

I've never seen it fail before trying to merge into features... but good thing it also breaks on master I guess, at least things are consistent.

Thanks

@blueyed blueyed merged commit d36c712 into pytest-dev:master Jan 16, 2020
@blueyed blueyed deleted the tests-fix-master branch January 16, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants