doc: revisit section about rootdir #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erheron you might want to take a look at this. 👍 |
nicoddemus
approved these changes
Jan 15, 2020
|
@nicoddemus , sorry for answering such late. After reading changes I've got a feeling that there should be done something slightly more than that. Frankly, this opinion comes from looking at diff and... to me it looks like not so big change. I don't have a clear idea about "more changes" i'm talking about, but... maybe some example (example of how rootdir shouldn't be used?) would help? It could be taken from one of the issues, where such confusing interaction was noticed 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #6376
(had this in a stash from looking at it the other day)