Some type annotation & check_untyped_defs fixes #6311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
force-pushed
the
type-annotations-10
branch
2 times, most recently
from
8a3c06e
to
838f7bf
Compare
blueyed
reviewed
Dec 30, 2019
bluetech
force-pushed
the
type-annotations-10
branch
from
838f7bf
to
6175738
Compare
|
Rebased on latest features (no conflicts). |
blueyed
reviewed
Jan 12, 2020
I'd rather see this enabled via mypy's config (see #6452), mostly to avoid diff churn. |
blueyed
approved these changes
Jan 17, 2020
| recorder.hook.pytest_runtest_logreport(report=rep) | ||
| rep2.passed = False | ||
| rep2.skipped = True | ||
| recorder.hook.pytest_runtest_logreport(report=rep2) |
There was a problem hiding this comment.
Diff churn like this makes me think that --allow-redefinition would be better (docs).
If not for "src" then maybe for "testing" at least, and maybe only per module there then?
There was a problem hiding this comment.
I personally think this makes the code less confusing. I generally prefer to fix than to use allow-redefinition, for clarity and for the occasional errors it catches. Though it might be slightly annoying sometimes.
|
@bluetech |
Also replace one direct call to `compile` with this flag with the equivalent wrapper `ast.parse`. This function can have a more precise type.
These are more "dirty" than the previous batch (that's why they were left out). The trouble is that `compile` can return either a code object or an AST depending on a flag, so we need to add an overload to make the common case Union free. But it's still worthwhile.
The expected_warning is optional.
bluetech
force-pushed
the
type-annotations-10
branch
from
6175738
to
9b41b05
Compare
bluetech
force-pushed
the
type-annotations-10
branch
from
9b41b05
to
3392be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits mostly finish annotating
_pytest/code/.The other commits fix
check_untyped_defserrors in a few test files. This discovered a couple of problems in the annotations, which are fixed.Most of the diff is adding
-> Noneto test functions. Also, because of a deficiency in mypy, exceptions defined on functions e.g.pytest.fail.Exceptiondon't work, so I replace them with the direct classes instead.