New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 5430 pass logs to junit report #6274
Merged
nicoddemus
merged 8 commits into
pytest-dev:master
from
zupermanzupereroe:bugfix-5430-pass-logs-to-junit-report
Dec 12, 2019
Merged
Bugfix 5430 pass logs to junit report #6274
nicoddemus
merged 8 commits into
pytest-dev:master
from
zupermanzupereroe:bugfix-5430-pass-logs-to-junit-report
Dec 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it report for tests failed not in a teardown phase
Update repository
…it report for tests failed not in a teardown phase
…b.com/zupermanzupereroe/pytest into bugfix-5430-pass-logs-to-junit-report
nicoddemus
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zupermanzupereroe, thanks a lot for this. Sorry for the delay. 👍
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Dec 12, 2019
Bugfix 5430 pass logs to junit report
nicoddemus
added
the
needs backport
applied to PRs, indicates that it should be ported to the current bug-fix branch
label
Dec 12, 2019
4.6 backport: #6338 |
asottile
added
backported
PR has been backported to the current bug-fix branch
and removed
needs backport
applied to PRs, indicates that it should be ported to the current bug-fix branch
labels
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that does not allow logs for failed test to be passed to junit report in case the test fails during the
call
phase.