Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 5430 pass logs to junit report #6274

Conversation

zupermanzupereroe
Copy link
Contributor

@zupermanzupereroe zupermanzupereroe commented Nov 25, 2019

This PR fixes a bug that does not allow logs for failed test to be passed to junit report in case the test fails during the call phase.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zupermanzupereroe, thanks a lot for this. Sorry for the delay. 👍

@nicoddemus nicoddemus merged commit 66c1a12 into pytest-dev:master Dec 12, 2019
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Dec 12, 2019
Bugfix 5430 pass logs to junit report
@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Dec 12, 2019
@nicoddemus
Copy link
Member

4.6 backport: #6338

@asottile asottile added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants