Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect result of getmodpath method. #6202

Merged
merged 2 commits into from Nov 18, 2019
Merged

Fix incorrect result of getmodpath method. #6202

merged 2 commits into from Nov 18, 2019

Conversation

linw1995
Copy link
Contributor

Resolves #6189

asottile
asottile reviewed Nov 17, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! mind adding a quick test which demonstrates this change?

@blueyed
Copy link
Contributor

blueyed commented Nov 17, 2019

@linw1995
Let me/us know if you'd rather like to skip this - I'd be happy to help you there with hardening some existing test, and if you like to do it yourself I suggest looking at existing tests and hardening them (hopefully there is one already triggering this, but just not matching strictly).

@linw1995
Copy link
Contributor Author

@blueyed Thank you for helping. @asottile I hardened one existing test for demonstrating this change.
hope it will be enough.

@nicoddemus
Copy link
Member

Thanks @linw1995, great finding and great PR. 👍

We could make a separate test for the fix, but the way it is now looks enough to me. 😁

@asottile asottile merged commit eeeb196 into pytest-dev:master Nov 18, 2019
@linw1995 linw1995 deleted the fix_getmodpath branch November 19, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile left review comments

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'.[' replaced with '[' in the headline shown of the test report
4 participants
@linw1995 @blueyed @nicoddemus @asottile