Update advice about _called_from_test. #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Nov 12, 2019
|
|
||
| .. code-block:: python | ||
|
|
||
| if hasattr(sys, "_called_from_test"): | ||
| if your_module._called_from_test: | ||
| # called from within a test run | ||
| ... | ||
| else: | ||
| # called "normally" | ||
| ... | ||
|
|
There was a problem hiding this comment.
i noted that we haven't yet a actual example execution block, so this example isn't actually executed demoing the effect -
There was a problem hiding this comment.
How do I do that?
There was a problem hiding this comment.
TBH I think the current example is fine, it is a really contrived use case anyways. 🤷♂
asottile
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
I think this is mergeable as is but will defer clicking the button until @RonnyPfannschmidt has had additional input 👍
nicoddemus
approved these changes
Nov 14, 2019
|
We should squash the commits before merging as well. |
Instead of giving an example of using sys and then, at the end, advising not to use sys, just give a correct example. This is especially helpful since mypy 0.740 has started (correctly) complaining about sys._called_from_pytest not being present.
|
please merge, having it as runner example take a bit of tinkering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of giving an example of using
sysand then, at the end, advising to not usesys, just give a preferred example. This is especially helpful since mypy 0.740 has started (correctly) complaining aboutsys._called_from_testnot being present.