New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest hangs if it tries to rewrite modules without having access rights on Windows 10 #5844
Comments
Hi @Sup3rGeo!
def _mkstemp_inner(dir, pre, suf, flags, output_type):
"""Code common to mkstemp, TemporaryFile, and NamedTemporaryFile."""
names = _get_candidate_names()
if output_type is bytes:
names = map(_os.fsencode, names)
for seq in range(TMP_MAX):
name = next(names)
file = _os.path.join(dir, pre + name + suf)
try:
fd = _os.open(file, flags, 0o600)
except FileExistsError:
continue # try again
except PermissionError:
# This exception is thrown when a directory with the chosen name
# already exists on windows.
if (_os.name == 'nt' and _os.path.isdir(dir) and
_os.access(dir, _os.W_OK)):
continue
else:
raise
return (fd, _os.path.abspath(file))
raise FileExistsError(_errno.EEXIST,
"No usable temporary file name found") The traceback shows it is hanging on the Strange, unfortunately this is hard to debug. 😕 |
According to this stackoverflow question, it seems this is a long lasting issue for windows that has not been yet fixed: https://bugs.python.org/issue22107 Let's hope the items mentioned by @sparrowt above will help workaround the issue for pytest. |
It would definitely help, but only for py38 users I'm afraid... 🤔 |
sadly this issue still exists on Windows 10, Python 3.8.6, pytest 6.1.2 😖 |
I guess a workaround would be to check for permission before calling into I've spent a few minutes trying to write a test for it: @pytest.mark.skipif(not sys.platform.startswith("win"), reason="Windows only (#5844)")
def test_write_pyc(tmp_path: Path, request) -> None:
cache_dir = tmp_path.joinpath("cache")
cache_dir.mkdir()
try:
cache_dir.chmod(0) # this doesn't work
with pytest.raises(PermissionError):
cache_dir.joinpath("foo").touch()
# call _write_pyc and check it returns False instead of hanging
finally:
cache_dir.chmod(stat.S_IWRITE) But unfortunately couldn't get |
Stumbled across this too... There are two issues:
os.fspath(pyc) may be read-only (on linux too?)
printing dir after these two lines in atomicwrites/init.py gives me C:\Program Files\Python38\lib\site-packages\hypothesis_pycache_ with is write protected. File "C:\Program Files\Python38\lib\site-packages_pytest\assertion\rewrite.py", line 165, in exec_module Calling pytest with --assert=plain is a work-around. |
Still broken on Win10, Python 3.9.6, pytest-6.2.4 And in my case pytest was trying to rewrite allure-pytest module under site-packages. I don't think pytest has to rewrite libraries. Did some more experiments and found out that:
And I think other workaround is not installing python under program files, but under your user. Didn't test it though. IMHO pytest should detect if it has write access, and either skip rewriting for modules he doesn't have access to, either write PYCs somewhere else in this case, either don't rewrite libraries within python at all. |
Another workaround maybe to use virtual environments (which have the user's rights). But how do the Linux guys handle this? They should get the same problem... |
Ran into this issue but couldn't use virtual environments out of the box since I am using a program that depends on using system-wide installed packages. The solution ended up being installing all my needed packages to the system and then creating a virtual environment with the command |
I have also been experiencing this issue (currently on Windows 10, Python 3.9.7, and pytest 7.1.1). I've observed that it happens after I've used |
Basically, it seems that if:
C:\Program files
(in a situation that you also have to runpip install
from an elevated command prompt in order to install packages)Then pytest just hangs. CTRL+C shows the following traceback:
I would expect it not to hang, but for it to terminate with a
Permission denied
message instead.Using Windows 10, python 3.6.8 and pytest 5.0.0
The text was updated successfully, but these errors were encountered: