Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reword a parametrize example sentence #5745

Merged
merged 1 commit into from Aug 15, 2019

Conversation

mei-li
Copy link
Contributor

@mei-li mei-li commented Aug 15, 2019

I found myself reading this sentence multiple times to understand it. I think splitting it makes more sense.

@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #5745 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5745      +/-   ##
==========================================
- Coverage   96.17%   96.12%   -0.06%     
==========================================
  Files         117      117              
  Lines       25910    25910              
  Branches     2500     2500              
==========================================
- Hits        24918    24905      -13     
- Misses        691      700       +9     
- Partials      301      305       +4
Impacted Files Coverage Δ
src/_pytest/compat.py 97.76% <0%> (-2.24%) ⬇️
src/_pytest/pathlib.py 89.63% <0%> (-1.04%) ⬇️
testing/test_pdb.py 98.01% <0%> (-1%) ⬇️
src/_pytest/assertion/rewrite.py 96.33% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d613a0...f4a84a8. Read the comment docs.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, appreciate taking the time to improve the docs! 👍

@nicoddemus nicoddemus merged commit ac052a9 into pytest-dev:master Aug 15, 2019
@mei-li mei-li deleted the parametrise-example-reword branch August 16, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants