New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async result warn #5742
Async result warn #5742
Conversation
018bd11
to
85b4266
Compare
85b4266
to
6b9d729
Compare
Codecov Report
@@ Coverage Diff @@
## master #5742 +/- ##
========================================
+ Coverage 93.1% 93.9% +0.8%
========================================
Files 117 117
Lines 25884 25888 +4
Branches 2498 2499 +1
========================================
+ Hits 24100 24311 +211
+ Misses 1444 1249 -195
+ Partials 340 328 -12
Continue to review full report at Codecov.
|
Do we really need this? I mean, Python itself already issues a warning which is clear enough IMHO: async def foo():
pass
def test_foo():
return foo()
|
Oh for the future: new warnings should target |
I'm experiencing the problem with twisted Deferreds, however. Where they are awaitable but no error is thrown if you do not await them and there is no way to determine if a function will return one statically like inspect.iscoro... |
Oh I see, thanks! |
master
branch for bug fixes, documentation updates and trivial changes.features
branch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.AUTHORS
in alphabetical order;