Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into features #5741

Closed
wants to merge 13 commits into from
Closed

Conversation

nicoddemus
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #5741 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5741      +/-   ##
============================================
+ Coverage     96.25%   96.25%   +<.01%     
============================================
  Files           117      117              
  Lines         25902    25903       +1     
  Branches       2495     2495              
============================================
+ Hits          24932    24933       +1     
  Misses          666      666              
  Partials        304      304
Impacted Files Coverage Δ
src/_pytest/pytester.py 90.8% <ø> (ø) ⬆️
src/_pytest/outcomes.py 98.5% <ø> (ø) ⬆️
testing/test_pastebin.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa75d81...998da2c. Read the comment docs.

doc/en/skipping.rst Outdated Show resolved Hide resolved
doc/en/skipping.rst Outdated Show resolved Hide resolved
src/_pytest/outcomes.py Outdated Show resolved Hide resolved
src/_pytest/pytester.py Outdated Show resolved Hide resolved
Co-Authored-By: Daniel Hahler <github@thequod.de>
@nicoddemus
Copy link
Member Author

Thanks!

@@ -27,6 +27,8 @@ pytest.skip

.. autofunction:: _pytest.outcomes.skip(msg, [allow_module_level=False])

.. _`pytest.importorskip ref`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _`pytest.importorskip ref`:
.. _`pytest.importorskip`:

To fix:

Warning, treated as error:
/home/travis/build/pytest-dev/pytest/doc/en/skipping.rst:182:undefined label: pytest.importorskip (if the link has no caption the label must precede a section header)

That's why I had a "?" with the suggestion.. ;)

@nicoddemus
Copy link
Member Author

Hmmm nevermind this branch then, I will re-do the merge once we merge the pending PRs. 👍

@nicoddemus nicoddemus closed this Aug 15, 2019
@nicoddemus nicoddemus deleted the mm branch August 15, 2019 13:05
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants