Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn about tests returning any non-None value #5735

Closed
4 tasks
graingert opened this issue Aug 12, 2019 · 1 comment
Closed
4 tasks

warn about tests returning any non-None value #5735

graingert opened this issue Aug 12, 2019 · 1 comment
Labels
topic: reporting related to terminal output and user-facing messages and errors type: enhancement new feature or API change, should be merged into features branch

Comments

@graingert
Copy link
Member

graingert commented Aug 12, 2019

Currently there's a warning for coroutine functions (async def) but not for

twisted.internet.defer.inlineCallbacks, where the only way to tell is the fact that the test returned a deferred

  • a detailed description of the bug or suggestion
  • output of pip list from the virtual environment you are using
  • pytest and operating system versions
  • minimal example if possible
@Zac-HD Zac-HD added topic: reporting related to terminal output and user-facing messages and errors type: enhancement new feature or API change, should be merged into features branch labels Aug 13, 2019
@Zac-HD
Copy link
Member

Zac-HD commented Sep 26, 2020

Closing as a duplicate of #7337 - while that issue is considerably newer, it also has the consensus plan to warn (and eventually error) on non-None return values 🙂

@Zac-HD Zac-HD closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: reporting related to terminal output and user-facing messages and errors type: enhancement new feature or API change, should be merged into features branch
Projects
None yet
Development

No branches or pull requests

2 participants