Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve quoting in raises match failure message #5553

Merged
merged 1 commit into from Jul 4, 2019
Merged

Improve quoting in raises match failure message #5553

merged 1 commit into from Jul 4, 2019

Conversation

asottile
Copy link
Member

@asottile asottile commented Jul 4, 2019

No description provided.

@asottile asottile mentioned this pull request Jul 4, 2019
Merged
nicoddemus
nicoddemus approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🙇

@codecov
Copy link

codecov bot commented Jul 4, 2019 •
edited

Codecov Report

Merging #5553 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5553      +/-   ##
==========================================
+ Coverage   96.11%   96.11%   +<.01%     
==========================================
  Files         117      117              
  Lines       25695    25701       +6     
  Branches     2493     2493              
==========================================
+ Hits        24696    24702       +6     
  Misses        695      695              
  Partials      304      304
Impacted Files Coverage Δ
src/_pytest/_code/code.py 94.32% <100%> (ø) ⬆️
testing/python/raises.py 94.48% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08ae44...caa08eb. Read the comment docs.

@nicoddemus nicoddemus merged commit 95824c5 into pytest-dev:master Jul 4, 2019
@asottile asottile deleted the better_quoting branch July 4, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asottile @nicoddemus