Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link deprecation docs pytest.raises 'message' warning #5421

Merged
merged 1 commit into from Jun 8, 2019

Conversation

nicoddemus
Copy link
Member

As commented in #3974 (comment)

@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Jun 7, 2019
@ndevenish
Copy link
Contributor

ndevenish commented Jun 7, 2019

Looks good - my one (minor) concern was linking to /latest/ - but it looks like you've accounted for that and old deprecations are kept listed on that page even after removal.

although it does look as though the anchor links change (everything before "Removed Features" has a deprecations.html#named-title-anchor whereas after has #id<num>), this is probably just a manual page-generation issue? And anyway, getting onto the right page is probably good enough.

From unfortunate experience, I know that some people remain stuck to old versions for quite some time, especially if v5 is dropping python 2.7.

@nicoddemus
Copy link
Member Author

nicoddemus commented Jun 7, 2019

my one (minor) concern was linking to /latest/

Great catch. I've changed the link to point to the 4.6-maintenance release docs instead. 👍

That link should remain valid and unchanged for a long time.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #5421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5421   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         114      114           
  Lines       25502    25502           
  Branches     2479     2479           
=======================================
  Hits        24479    24479           
  Misses        717      717           
  Partials      306      306
Impacted Files Coverage Δ
src/_pytest/deprecated.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f597f0...f0cee59. Read the comment docs.

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 83d1809 into pytest-dev:master Jun 8, 2019
@asottile asottile added backported PR has been backported to the current bug-fix branch and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR has been backported to the current bug-fix branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants