Fix verbosity bug in --collect-only

[twmr]

Closes: #5383

• Target the master branch for bug fixes, documentation updates and trivial changes.
• Target the features branch for new features and removals/deprecations.
• Include documentation when adding new features.
• Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

• Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
• Add yourself to AUTHORS in alphabetical order;

[twmr]

I'm a bit surprised that this hook is called even when --collect-only is used

[codecov]

Codecov Report

Merging #5391 into master will decrease coverage by <.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #5391      +/-   ##
==========================================
- Coverage   95.98%   95.98%   -0.01%     
==========================================
  Files         114      114              
  Lines       25496    25512      +16     
  Branches     2474     2478       +4     
==========================================
+ Hits        24473    24488      +15     
  Misses        718      718              
- Partials      305      306       +1

Impacted Files	Coverage Δ
src/_pytest/logging.py	95.85% <100%> (+0.03%)	⬆️
testing/logging/test_reporting.py	99.66% <92.3%> (-0.34%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be84ba8...577b0df. Read the comment docs.

[nicoddemus]

Thanks @thisch for the quick PR!

While it fixes the main problem, using log-cli-level still produces the === section:

λ pytest .tmp\test-foo.py --collect-only -q
test-foo.py::test_post_mortem

no tests ran in 0.01 seconds

 λ pytest .tmp\test-foo.py --collect-only -q --log-cli-level=INFO
test-foo.py::test_post_mortem

=================== no tests ran in 0.01 seconds ====================

[nicoddemus]

Do we still want to capture log messages during --collect-only? If not this patch (over this PR) fixes this:

diff --git a/src/_pytest/logging.py b/src/_pytest/logging.py
index f8ff0362c..1cffda1c3 100644
--- a/src/_pytest/logging.py
+++ b/src/_pytest/logging.py
@@ -624,16 +624,19 @@ class LoggingPlugin:
     @pytest.hookimpl(hookwrapper=True)
     def pytest_runtestloop(self, session):
         """Runs all collected test items."""
-        if self._log_cli_enabled() and self._config.getoption("verbose") < 1:
-            # setting verbose flag is needed to avoid messy test progress output
-            self._config.option.verbose = 1
-
-        with self.live_logs_context():
-            if self.log_file_handler is not None:
-                with catching_logs(self.log_file_handler, level=self.log_file_level):
+        if session.config.option.collectonly:
+            yield
+        else:
+            if self._log_cli_enabled() and self._config.getoption("verbose") < 1:
+                # setting verbose flag is needed to avoid messy test progress output
+                self._config.option.verbose = 1
+
+            with self.live_logs_context():
+                if self.log_file_handler is not None:
+                    with catching_logs(self.log_file_handler, level=self.log_file_level):
+                        yield  # run all the tests
+                else:
                     yield  # run all the tests
-            else:
-                yield  # run all the tests

[twmr]

Do we still want to capture log messages during --collect-only? If not this patch (over this PR) fixes this:

I dont understand your comment. live-logging/capturing of the log messages that are created in the collection phase still works, even with your patch.

Note that I've already applied your patch, thx!

[nicoddemus]

I dont understand your comment. live-logging/capturing of the log messages that are created in the collection phase still works, even with your patch.

Sorry, I was not very clear: I meant that my patch fixes the output difference from my previous comment (the ==== no tests run in ... ==== footer).

[nicoddemus]

Backport: #5411