Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6] Fix pytest.mark.parametrize when the argvalue is an iterator #5357

Merged
merged 1 commit into from Jun 1, 2019
Merged

Conversation

asottile
Copy link
Member

@asottile asottile commented Jun 1, 2019

Backport of #5356

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #5357 into 4.6-maintenance will decrease coverage by 4.9%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           4.6-maintenance    #5357      +/-   ##
===================================================
- Coverage            95.32%   90.41%   -4.91%     
===================================================
  Files                  115      115              
  Lines                26384    26391       +7     
  Branches              2607     2607              
===================================================
- Hits                 25150    23861    -1289     
- Misses                 924     2205    +1281     
- Partials               310      325      +15
Impacted Files Coverage Δ
testing/test_mark.py 99.39% <100%> (ø) ⬆️
src/_pytest/mark/structures.py 92.73% <100%> (+0.08%) ⬆️
testing/test_reports.py 10.49% <0%> (-89.51%) ⬇️
testing/test_runner_xunit.py 29.82% <0%> (-70.18%) ⬇️
testing/test_warnings.py 26.77% <0%> (-68.86%) ⬇️
testing/examples/test_issue519.py 33.33% <0%> (-66.67%) ⬇️
testing/test_runner.py 34.7% <0%> (-61.61%) ⬇️
testing/test_resultlog.py 53.6% <0%> (-46.4%) ⬇️
testing/test_pytester.py 55.21% <0%> (-34.09%) ⬇️
src/_pytest/reports.py 68.96% <0%> (-26.11%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917195e...f7bf914. Read the comment docs.

@nicoddemus nicoddemus merged commit dba62f8 into pytest-dev:4.6-maintenance Jun 1, 2019
@asottile asottile deleted the backport_5356 branch June 1, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants