Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs for pytest.raises match. #5223

Merged
merged 3 commits into from May 7, 2019

Conversation

peterschutt
Copy link
Contributor

@peterschutt peterschutt commented May 7, 2019

Fix #5208.

Document explicit behavior of match and brief note on how to handle matching a string that may contain special re chars.

For pytest-dev#5208.

Document explicit behavior of `match` and brief note on how to handle matching a string that may contain special re chars.
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @5uper5hoot!

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #5223 into master will decrease coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5223      +/-   ##
==========================================
- Coverage   96.06%   95.09%   -0.98%     
==========================================
  Files         114      114              
  Lines       25824    25824              
  Branches     2550     2550              
==========================================
- Hits        24809    24558     -251     
- Misses        705      944     +239     
- Partials      310      322      +12
Impacted Files Coverage Δ
src/_pytest/python_api.py 97.48% <ø> (ø) ⬆️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 33.33% <0%> (-41.67%) ⬇️
testing/test_conftest.py 90.4% <0%> (-9.23%) ⬇️
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
src/_pytest/pytester.py 85.71% <0%> (-5.4%) ⬇️
testing/test_collection.py 95.29% <0%> (-4.52%) ⬇️
testing/test_tmpdir.py 94.62% <0%> (-4.31%) ⬇️
src/_pytest/assertion/util.py 93.38% <0%> (-4.29%) ⬇️
testing/test_parseopt.py 94.73% <0%> (-3.24%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf65a9...d368636. Read the comment docs.

@nicoddemus
Copy link
Member

Linting passed, merging. 👍

@nicoddemus nicoddemus merged commit 6d259c4 into pytest-dev:master May 7, 2019
@wimglenn
Copy link
Member

wimglenn commented Dec 2, 2021

Good to see this was clarified better, it was one of my gripes in #4538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement to documentation of pytest.raises() match parameter.
3 participants