Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_assertrewrite fails when run in verbose mode #4879

Closed
blueyed opened this issue Mar 4, 2019 · 0 comments
Closed

test_assertrewrite fails when run in verbose mode #4879

blueyed opened this issue Mar 4, 2019 · 0 comments
Labels
type: bug problem that needs to be addressed

Comments

@blueyed
Copy link
Contributor

blueyed commented Mar 4, 2019 

FAILED testing/test_assertrewrite.py::TestAssertionRewrite::test_dont_rewrite_if_hasattr_fails
FAILED testing/test_assertrewrite.py::TestAssertionRewrite::test_len
FAILED testing/test_assertrewrite.py::TestAssertionRewrite::test_custom_repr
FAILED testing/test_assertrewrite.py::TestAssertionRewrite::test_name

The problem seems to be that those tests themselves get rewritten differently when using verbose mode or not.

I think there should be different assertions based on request.config.verbose?!

Originally posted by @blueyed in #4851 (comment)
@blueyed blueyed added the type: bug problem that needs to be addressed label Mar 4, 2019
@blueyed blueyed mentioned this issue Mar 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug problem that needs to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blueyed