Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for flake8 3.7 #4693

Merged
merged 2 commits into from
Jan 30, 2019
Merged

fixes for flake8 3.7 #4693

merged 2 commits into from
Jan 30, 2019

Conversation

asottile
Copy link
Member

I opted to remove the PEP 484 type comment annotations for now since we're not linting for mypy

Also upgraded the pre-commit hooks since virtualenv has been released fixing the weird black issue that was happening before

@nicoddemus nicoddemus merged commit b96e162 into pytest-dev:master Jan 30, 2019
@asottile asottile deleted the flake8_3_7_0 branch January 30, 2019 15:24
@blueyed
Copy link
Contributor

blueyed commented Jan 31, 2019

I opted to remove the PEP 484 type comment annotations for now since we're not linting for mypy

Does flake8 complain about them?

@asottile
Copy link
Member Author

I opted to remove the PEP 484 type comment annotations for now since we're not linting for mypy

Does flake8 complain about them?

pyflakes 2.1 now recognizes PEP 484 # type: ... comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asottile @blueyed @nicoddemus