Merge master into features (prepare for 3.9, pt2) #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests: clarify/document/harden acceptance tests
In the proposed new style using `@pytest.mark.parametrize`, the example function signature missed the actual arguments. Add the missing arguments
docs: deprecation.rst: Add missing arguments to example code
Minor: code style / constant
This gets printed by the terminal reporter already, and currently results in the same error being displayed twice, e.g. when raising an `Exception` manually from `pytest.debugging.pytest_exception_interact`.
`help quit` in pdb says: > Quit from the debugger. The program being executed is aborted. But pytest would continue with the next tests, often making it necessary to kill the pytest process when using `--pdb` and trying to cancel the tests using `KeyboardInterrupt` / `Ctrl-C`.
- no need for {posargs:testing} really
- remove `-ra`, used with addopts already
…rations Exclude durations that are 0.00 seconds long.
Do not print (duplicate) INTERNALERROR with --pdb.
pdb: handle quitting in post_mortem
tox.ini: pexpect: use posargs; cleanup posargs
This is required to pass through COVERAGE_PROCESS_START etc.
Given the setup time for jobs, it makes sense to run *-pexpect,*-trial,*-numpy in a single build job.
This runs py27, py37 and linting first - simulating the baseline stage used on Travis.
Unfortunately due to fluctuations in runtime "test_something" might still appear in the final message. Example failure: https://ci.appveyor.com/project/pytestbot/pytest/builds/19494829/job/8lx847u0c78m63wf
tox.ini: passenv: COVERAGE_*
tox.ini: clean up changedir
…s-test Fix flaky durations test
```console $ cd t && rm -rf __pycache__ && pytest t.py -q -c /dev/null; cd .. . [100%] =============================== warnings summary =============================== <unknown>:2: DeprecationWarning: invalid escape sequence \. -- Docs: https://docs.pytest.org/en/latest/warnings.html 1 passed, 1 warnings in 0.01 seconds ``` ```console $ cd t && rm -rf __pycache__ && pytest t.py -q -c /dev/null; cd .. . [100%] =============================== warnings summary =============================== /tmp/pytest/t/t.py:2: DeprecationWarning: invalid escape sequence \. '\.wat' -- Docs: https://docs.pytest.org/en/latest/warnings.html 1 passed, 1 warnings in 0.01 seconds ```
Hopefully Closes: pytest-dev#4151
…e_on_how_to_use_pytester_to_the_CONTRIBUTING_guide_4151 Add testdir examples to CONTRIBUTING guide
Display the filename when encountering `SyntaxWarning`.
Use full link to changelog's README in PR template
RonnyPfannschmidt
approved these changes
Oct 15, 2018
Codecov Report
@@ Coverage Diff @@
## features #4158 +/- ##
============================================
+ Coverage 94.45% 95.79% +1.34%
============================================
Files 109 109
Lines 24193 24208 +15
Branches 2384 2387 +3
============================================
+ Hits 22852 23191 +339
+ Misses 1023 721 -302
+ Partials 318 296 -22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;