Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new API #3654

Merged
merged 3 commits into from Jul 4, 2018
Merged

Switch to new API #3654

merged 3 commits into from Jul 4, 2018

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented Jul 3, 2018 •
edited

Fixes #3653

@coveralls
Copy link

coveralls commented Jul 3, 2018 •
edited

Coverage Status

Coverage increased (+0.05%) to 92.65% when pulling b84a646 on LeastAuthority:3653.deprecated-convert into b509112 on pytest-dev:master.

@nicoddemus
Copy link
Member

Thanks @exarkun!

@nicoddemus
Copy link
Member

Btw, we don't catch that warning because unfortunately we don't yet capture deprecation warnings at import time.

@nicoddemus nicoddemus merged commit 3ed8e28 into pytest-dev:master Jul 4, 2018
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Jul 4, 2018
Open
@exarkun
Copy link
Contributor Author

exarkun commented Jul 5, 2018

Thanks for the quick turn-around on this. My CI was failing but the fixed release came out so quickly I didn't even have time to implement a work-around on my side. Much appreciated. :)

@exarkun exarkun deleted the 3653.deprecated-convert branch July 5, 2018 13:15
@nicoddemus
Copy link
Member

No worries, thanks again for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exarkun @coveralls @nicoddemus