Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users configure dist mode in the configuration file #851

Merged
merged 1 commit into from Dec 1, 2022

Conversation

nicoddemus
Copy link
Member

Fix #789

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we ought o consider having a ini option for the default dist mode which is cleaner than addopts (similar to the logging plugin

@nicoddemus
Copy link
Member Author

nicoddemus commented Dec 1, 2022

Thanks @RonnyPfannschmidt for the review.

we ought o consider having a ini option for the default dist mode which is cleaner than addopts (similar to the logging plugin

I was writing my rationale why I think it is not necessary and it turned out to be quite verbose, so I decided instead to turn that into an issue in pytest so we can bring more people to the discussion. 👍

Please read my rationale there, and if you still feel strongly we should have a dedicated option for it, I will be glad to do it in a follow-up (because another small option would not really be the end of the world). It is also arguable that --dist should have been a configuration option in the first place.

I think this is worthwhile to merge anyway as it provides a fix for the original issue and cleans up the code a bit, removing what seemed to be a wart that --dist without -n would give a cryptic message like that.

@nicoddemus nicoddemus merged commit 6226965 into pytest-dev:master Dec 1, 2022
@nicoddemus nicoddemus deleted the 789-default-dist-mode branch December 1, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to set the default distribution algorithm
2 participants