Add explicit 'logical' choice to --numprocesses flag #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroeschl
force-pushed
the
numprocesses-logical
branch
from
041971c
to
1f4cdb8
Compare
nicoddemus
requested changes
Apr 27, 2021
This can significantly speed up runs when testing is not CPU-bound.
kroeschl
force-pushed
the
numprocesses-logical
branch
from
1f4cdb8
to
4d27110
Compare
nicoddemus
reviewed
Apr 27, 2021
nicoddemus
reviewed
Apr 27, 2021
|
@nicoddemus is this going to be released soon? I am attempting to use this for a project. |
RonnyPfannschmidt
approved these changes
Jun 8, 2021
|
missed this one, thanks for the poke, next release will have it |
|
Thanks @RonnyPfannschmidt! Do you know when that next release will be? |
|
@joshua-s the 2 items i have to complete is full support for git archives (including non-tag archives for git >=2.32) and enhancemens of the errors when using bad pip/setuptools for modern setuptools_scm |
|
hmm, #tfw when you respond for the wrong project, definitively time for a weekend @nicoddemus should we do one early next week |
Sounds good to me. Would you like to do it, or want me to do it? |
gcf-merge-on-green bot
pushed a commit
to GoogleCloudPlatform/python-docs-samples
that referenced
this pull request
Aug 3, 2021
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pytest-xdist](https://togithub.com/pytest-dev/pytest-xdist) | `==2.2.1` -> `==2.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pytest-dev/pytest-xdist</summary> ### [`v2.3.0`](https://togithub.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst#pytest-xdist-230-2021-06-16) [Compare Source](https://togithub.com/pytest-dev/pytest-xdist/compare/v2.2.1...v2.3.0) \=============================== ## Deprecations and Removals - `#​654 <https://github.com/pytest-dev/pytest-xdist/issues/654>`\_: Python 3.5 is no longer supported. ## Features - `#​646 <https://github.com/pytest-dev/pytest-xdist/issues/646>`\_: Add `--numprocesses=logical` flag, which automatically uses the number of logical CPUs available, instead of physical CPUs with `auto`. This is very useful for test suites which are not CPU-bound. - `#​650 <https://github.com/pytest-dev/pytest-xdist/issues/650>`\_: Added new `pytest_handlecrashitem` hook to allow handling and rescheduling crashed items. ## Bug Fixes - `#​421 <https://github.com/pytest-dev/pytest-xdist/issues/421>`\_: Copy the parent process sys.path into local workers, to work around execnet's python -c adding the current directory to sys.path. - `#​638 <https://github.com/pytest-dev/pytest-xdist/issues/638>`\_: Fix issue caused by changing the branch name of the pytest repository. ## Trivial Changes - `#​592 <https://github.com/pytest-dev/pytest-xdist/issues/592>`\_: Replace master with controller where ever possible. - `#​643 <https://github.com/pytest-dev/pytest-xdist/issues/643>`\_: Use 'main' to refer to pytest default branch in tox env names. </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/python-docs-samples).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change to physical CPU count in #560, test sets that are run with
psutilinstalled and that are not CPU-bound (in my case, with lots of network activity) take roughly twice as long to execute on hyperthreaded CPUs. Add a new choicelogicalfor flag--numprocessesfor use cases like this.This implementation is a bit weird because of the multiple fallback paths in
pytest_xdist_auto_num_workers()which all return the logical CPU count already, but I don't see a better option.Testing:
toxagainst all butpython3.5on Linux:--numprocesses logicalon my six-core hyperthreaded CPU.