Use psutil.cpu_count(logical=False) in auto_detect_cpus() #560
Conversation
src/xdist/plugin.py
Outdated
|
|
||
| try: | ||
| n = cpu_count() | ||
| n = psutil.cpu_count(logical=False) | ||
| except NotImplementedError: |
There was a problem hiding this comment.
is this something that psutil will raise?
Return the number of logical CPUs in the system (same as os.cpu_count in Python 3.4) or None if undetermined. logical cores means the number of physical cores multiplied by the number of threads that can run on each core (this is known as Hyper Threading). If logical is False return the number of physical cores only (Hyper Thread CPUs are excluded) or None if undetermined. On OpenBSD and NetBSD psutil.cpu_count(logical=False) always return None. Example on a system having 2 physical hyper-thread CPU cores:
if it never raises, we can use return psutil.cpu_count(logical=False) or 1
There was a problem hiding this comment.
I'm also concerned about:
On OpenBSD and NetBSD psutil.cpu_count(logical=False) always return None.
should we fallback to the old code if we get a None?
There was a problem hiding this comment.
should we fallback to the old code if we get a None?
Not sure, we don't officially support OpenBSD and NetBSD... your suggestion above of using return psutil.cpu_count(logical=False) or 1 would at least prevent a crash, and I would rather keep the code cleaner. But if others disagree then I think your suggestion is on point.
There was a problem hiding this comment.
Does this obviate the Travis workaround?
There was a problem hiding this comment.
I tested this locally on pypy35:
Fixes #553.