Fix issues related to running xdist with the terminal plugin disabled #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the pytest plugin manager returns None if a plugin is not loaded instead of raising an error. It also makes terminal optional in plugin code.
|
I found another little issue regarding this. Also adding a test. |
RonnyPfannschmidt
approved these changes
Sep 12, 2019
|
Thanks! I assume that not many people run xdist without terminal output. |
|
@RonnyPfannschmidt is it possible to release this? I tried following the release instructions but it looks like those are intended for maintainers because they require push access. |
|
Yup, another maintainer will have to do, I'm traveling to the sea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the pluggy plugin manager returns None if a plugin is not loaded instead of raising an error.
It also makes terminal optional in plugin code.